This repository was archived by the owner on Aug 19, 2022. It is now read-only.
Adding enhancer tests for better coverage#310
Merged
ianobermiller merged 2 commits intoFormidableLabs:masterfrom Aug 11, 2015
Merged
Adding enhancer tests for better coverage#310ianobermiller merged 2 commits intoFormidableLabs:masterfrom
ianobermiller merged 2 commits intoFormidableLabs:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
we should probably be consistent and always require react/addons in tests, might help a bit with speed (just conjecture).
Contributor
Author
There was a problem hiding this comment.
After some crude testing it doesn't look like it makes much of a difference (if it does, it's very marginal), but we should do this for consistency's sake anyway - so here it is: #312
Contributor
|
Sweet! 🚀 |
ianobermiller
added a commit
that referenced
this pull request
Aug 11, 2015
Adding Enhancer tests for better coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #264 by bringing in better test coverage to the enhancer.